Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch instances monitoring from cluster to user-workload monitoring #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Dec 12, 2024

Summary

This PR will switch the monitoring of the instances from cluster monitoring to user-workload monitoring.
This is required to have alerting and monitoring work for the end users

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee force-pushed the user-workload-monitoring branch from 3e88a3f to 4f9935c Compare December 13, 2024 14:14
@TheBigLee TheBigLee requested review from a team, Kidswiss, wejdross and zugao and removed request for a team December 13, 2024 15:16
Labels: map[string]string{
// This label is required, the ensure that the rule is added to Prometheus and
// not the Thanos Rules in the Openshift User Workload Monitoring
"openshift.io/prometheus-rule-evaluation-scope": "leaf-prometheus",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly, that this is the magic sauce that will make the billing data go to the right place in mimir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants