Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SLA alert name #625

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix SLA alert name #625

merged 1 commit into from
Feb 5, 2025

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Feb 5, 2025 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@TheBigLee
Fix SLA alert name
e4470bf 
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee TheBigLee added enhancement New feature or request patch labels Feb 5, 2025
@TheBigLee TheBigLee requested review from a team, Kidswiss, wejdross and zugao and removed request for a team February 5, 2025 15:30
zugao
zugao reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHat's the problem? They are not working?

@TheBigLee TheBigLee added change and removed enhancement New feature or request labels Feb 5, 2025
@TheBigLee
Copy link
Member Author

TheBigLee commented Feb 5, 2025 •
edited
Loading

WHat's the problem? They are not working?

They are working, but the alert name is a bit convoluted and not well readable.
Furthermore, it doesn't follow the best practice of having camel case names for alerts

@TheBigLee TheBigLee removed the change label Feb 5, 2025
@TheBigLee TheBigLee requested a review from zugao February 5, 2025 15:42
zugao
zugao reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBigLee TheBigLee enabled auto-merge February 5, 2025 16:04
@TheBigLee TheBigLee merged commit 9bd2ef4 into master Feb 5, 2025
10 checks passed
@TheBigLee TheBigLee deleted the fix/alertname branch February 5, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss Kidswiss was automatically assigned from vshn/schedar

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBigLee @zugao