Add initial vcluster support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBigLee
force-pushed
the
add/vcluster
branch
from
400cd56 to
abe2449
Compare
TheBigLee
force-pushed
the
add/vcluster
branch
5 times, most recently
from
8bc4057 to
7820a58
Compare
TheBigLee
force-pushed
the
add/vcluster
branch
from
7820a58 to
2bbb9f2
Compare
Kidswiss
force-pushed
the
add/vcluster
branch
4 times, most recently
from
2b5ff22 to
1cd1dc9
Compare
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
wejdross
requested changes
Dec 4, 2024
There was a problem hiding this comment.
some changes from my side, also
deployment.apps/cert-manager condition met
kubectl -n cert-manager wait --for condition=Available deployment/cert-manager-webhook --timeout 120s
deployment.apps/cert-manager-webhook condition met
make[1]: Leaving directory '/home/wejdross/vshn/shedar/kindev'
13:54:29 fatal current selected context "" is not a virtual cluster context. If you've used a custom context name you will need to switch manually using kubectl
make: *** [Makefile:88: /home/wejdross/vshn/shedar/kindev/.kind/certmanager-sentinel] Error 1
setup using command: make vshnall -e vcluster=true fails
This will help with developing for splitted clusters, where crossplane and the services are not on the same clusters.
Kidswiss
force-pushed
the
add/vcluster
branch
from
145f3b0 to
5dd1ea5
Compare
The problem was with an incompatible helm release. wejdross: Helm was OK, vcluster version checker was problematic :D |
zugao
approved these changes
Dec 5, 2024
wejdross
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with developing for splitted clusters, where crossplane and the services are not on the same clusters.