Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with APPUiO #25

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Improve compatibility with APPUiO #25

merged 1 commit into from
Nov 7, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Nov 7, 2024

Now with k8s 1.29.x and networkpolicy support.

Also installs espejo with a rule to create an approximation of APPUiO's default network policies in each appcat namespace.

@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team November 7, 2024 13:57
Copy link

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would set the espejo deployment and all its rbac into a different folder, for better grouping

@Kidswiss
Copy link
Contributor Author

Kidswiss commented Nov 7, 2024

LGTM but I would set the espejo deployment and all its rbac into a different folder, for better grouping

Should I also create a separate make target then? one for espejo und one for the whole netpol stuff?

@tobru tobru changed the title Improvie APPUiO compatibility Improve APPUiO compatibility Nov 7, 2024
@tobru tobru changed the title Improve APPUiO compatibility Improve compatibility with APPUiO Nov 7, 2024
@zugao
Copy link

zugao commented Nov 7, 2024

LGTM but I would set the espejo deployment and all its rbac into a different folder, for better grouping

Should I also create a separate make target then? one for espejo und one for the whole netpol stuff?

would be better in my opinion and more clear. I would not be surprised if we would soon have custom rbac permissions simulated here with Espejo.

Now with k8s 1.29.x and networkpolicy support.

Also installs espejo with a rule to create an approximation of APPUiO's
default network policies in each appcat namespace.
@Kidswiss
Copy link
Contributor Author

Kidswiss commented Nov 7, 2024

LGTM but I would set the espejo deployment and all its rbac into a different folder, for better grouping

Should I also create a separate make target then? one for espejo und one for the whole netpol stuff?

would be better in my opinion and more clear. I would not be surprised if we would soon have custom rbac permissions simulated here with Espejo.

Done

@tobru I also fixed the typo in the commit :D

@Kidswiss Kidswiss merged commit 466a67f into master Nov 7, 2024
2 checks passed
Copy link

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants