Introduce disabling envs for namespace resources

vshn · Jun 20, 2023 · 2c6f9b1 · 2c6f9b1
1 parent fbd9183
commit 2c6f9b1
Show file tree

Hide file tree

Showing 5 changed files with 92 additions and 4 deletions.
diff --git a/controllers/stardoginstance_controller.go b/controllers/stardoginstance_controller.go
@@ -51,6 +51,10 @@ func (r *StardogInstanceReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 		return ctrl.Result{Requeue: true, RequeueAfter: ReconFreqErr}, err
 	}
 
+	if environmentDisabled(stardogInstance) {
+		return ctrl.Result{Requeue: false}, nil
+	}
+
 	sir := &StardogInstanceReconciliation{
 		reconciliationContext: &ReconciliationContext{
 			context:       ctx,

diff --git a/controllers/stardogrole_controller.go b/controllers/stardogrole_controller.go
@@ -54,6 +54,10 @@ func (r *StardogRoleReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		return ctrl.Result{Requeue: true, RequeueAfter: ReconFreqErr}, err
 	}
 
+	if environmentDisabled(stardogRole) {
+		return ctrl.Result{Requeue: false}, nil
+	}
+
 	srr := &StardogRoleReconciliation{
 		reconciliationContext: &ReconciliationContext{
 			context:       ctx,

diff --git a/controllers/stardoguser_controller.go b/controllers/stardoguser_controller.go
@@ -51,6 +51,10 @@ func (r *StardogUserReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		return ctrl.Result{Requeue: true, RequeueAfter: ReconFreqErr}, err
 	}
 
+	if environmentDisabled(stardogUser) {
+		return ctrl.Result{Requeue: false}, nil
+	}
+
 	sur := &StardogUserReconciliation{
 		reconciliationContext: &ReconciliationContext{
 			context:       ctx,

diff --git a/controllers/util.go b/controllers/util.go
@@ -11,6 +11,7 @@ import (
 	"github.com/vshn/stardog-userrole-operator/stardogrest/models"
 	"os"
 	"reflect"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 	"strings"
 	"time"
 
@@ -21,14 +22,16 @@ import (
 )
 
 var (
-	ReconFreqErr = time.Second * 30
-	ReconFreq    = time.Duration(0)
+	ReconFreqErr         = time.Second * 30
+	ReconFreq            = time.Duration(0)
+	disabledEnvironments = ""
 )
 
 // InitEnv initialize env variables
 func InitEnv() {
 	ReconFreqErr, _ = time.ParseDuration(os.Getenv("RECONCILIATION_FREQUENCY_ON_ERROR"))
 	ReconFreq, _ = time.ParseDuration(os.Getenv("RECONCILIATION_FREQUENCY"))
+	disabledEnvironments = os.Getenv("DISABLED_ENVIRONMENTS")
 	if ReconFreq < 0 || ReconFreqErr < 0 {
 		ReconFreq = 0
 		ReconFreqErr = 0
@@ -241,3 +244,15 @@ func NotFound(err error) bool {
 		errType == reflect.TypeOf(users_permissions.NewRemoveUserPermissionNotFound()).String() ||
 		errType == reflect.TypeOf(db.NewGetDBSizeNotFound()).String()
 }
+
+func environmentDisabled(object client.Object) bool {
+	if disabledEnvironments == "" {
+		return false
+	}
+	for _, env := range strings.Split(disabledEnvironments, ";") {
+		if env == object.GetNamespace() {
+			return true
+		}
+	}
+	return false
+}
diff --git a/controllers/util_test.go b/controllers/util_test.go
@@ -1,5 +1,3 @@
-//go:build exclude
-
 package controllers
 
 import (
@@ -15,6 +13,69 @@ import (
 	"time"
 )
 
+func Test_disabledEnvironments(t *testing.T) {
+	tests := []struct {
+		name       string
+		user       StardogUser
+		setEnv     func()
+		expectBool bool
+	}{
+		{
+			name: "GivenNoEnvVariableAndSecret_ThenReturnFalse",
+			user: StardogUser{
+				ObjectMeta: metav1.ObjectMeta{Namespace: "stardog-test"},
+			},
+			setEnv:     func() {},
+			expectBool: false,
+		},
+		{
+			name: "GivenWrongEnvVariableAndSecret_ThenReturnFalse",
+			user: StardogUser{
+				ObjectMeta: metav1.ObjectMeta{Namespace: "stardog-test"},
+			},
+			setEnv: func() {
+				os.Setenv("DISABLED_ENVIRONMENTS", "stardog-non.exists")
+			},
+			expectBool: false,
+		},
+		{
+			name: "GivenOneMatchingEnvVariableAndSecret_ThenReturnTrue",
+			user: StardogUser{
+				ObjectMeta: metav1.ObjectMeta{Namespace: "stardog-test"},
+			},
+			setEnv: func() {
+				os.Setenv("DISABLED_ENVIRONMENTS", "stardog-test")
+			},
+			expectBool: true,
+		},
+		{
+			name: "GivenMoreEnvsWithOneMatchingEnvVariableAndSecret_ThenReturnTrue",
+			user: StardogUser{
+				ObjectMeta: metav1.ObjectMeta{Namespace: "stardog-test"},
+			},
+			setEnv: func() {
+				os.Setenv("DISABLED_ENVIRONMENTS", "stardog-test;stardog-prod")
+			},
+			expectBool: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+
+			// GIVEN
+			tt.setEnv()
+			InitEnv()
+
+			// WHEN
+			disabled := environmentDisabled(&tt.user)
+
+			// THEN
+			assert.Equal(t, tt.expectBool, disabled)
+			os.Unsetenv("DISABLED_ENVIRONMENTS")
+		})
+	}
+}
+
 func Test_getData(t *testing.T) {
 
 	tests := []struct {