-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uro3 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review the logic itself, as I don't know how Stardog works, but I found some things that a bit ugly from a code point of view.
Kidswiss
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR adds the concept of hidden graphs. For each graph added through the organisation resource the user can create a new hidden graph with
addHidden = true
. The tool will create a second graph with the same link but appended with/hidden
at the end.In order to make use of these hidden graphs the permissions must be altered to specific users. This can always be done via stardoguser and stardorole resources. For permissions that need only access to hidden graphs a new custom user has been introduced per database
AddUserForNonHiddenGraphs
. The field is used to specify a name and the tool will make sure to dynamically update the permissions of this user in Stardog.Also with this update, an instance can be temporarily disabled via
disabled
field.Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog