Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uro3 #71

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Uro3 #71

merged 6 commits into from
Mar 25, 2024

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Mar 19, 2024

Summary

  • Added the concept of a hidden graph.
  • Added a custom user for database resource that is dynamically managed.
  • Added the feature to temporarily disable instance reconciliation.

Details

This PR adds the concept of hidden graphs. For each graph added through the organisation resource the user can create a new hidden graph with addHidden = true. The tool will create a second graph with the same link but appended with /hidden at the end.
In order to make use of these hidden graphs the permissions must be altered to specific users. This can always be done via stardoguser and stardorole resources. For permissions that need only access to hidden graphs a new custom user has been introduced per database AddUserForNonHiddenGraphs. The field is used to specify a name and the tool will make sure to dynamically update the permissions of this user in Stardog.
Also with this update, an instance can be temporarily disabled via disabled field.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@zugao zugao added the enhancement New feature or request label Mar 19, 2024
@zugao zugao marked this pull request as draft March 19, 2024 13:12
@zugao zugao marked this pull request as ready for review March 21, 2024 10:57
Copy link

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the logic itself, as I don't know how Stardog works, but I found some things that a bit ugly from a code point of view.

controllers/database_controller.go Outdated Show resolved Hide resolved
controllers/database_controller.go Outdated Show resolved Hide resolved
controllers/organization_controller.go Outdated Show resolved Hide resolved
controllers/organization_controller.go Outdated Show resolved Hide resolved
controllers/stardogrole_controller.go Outdated Show resolved Hide resolved
controllers/stardogrole_controller.go Outdated Show resolved Hide resolved
controllers/stardoguser_controller.go Outdated Show resolved Hide resolved
controllers/stardoguser_controller.go Outdated Show resolved Hide resolved
@zugao zugao requested a review from Kidswiss March 25, 2024 10:39
@zugao zugao merged commit ecf682b into master Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants