Fixed an issue under some circumstances when job.cancel() was run o…

…n a job with option `{ dependents: false }`.

HISTORY.md

@@ -1,8 +1,12 @@
 ## Revision history
 
+#### V.NEXT
+
+* Fixed an issue under some circumstances when `job.cancel()` was run on a job with option `{ dependents: false }`. Thanks @gbhrdt.
+
 #### 1.5.1
 
-* Fixed issue introduced in 1.5.0 which caused `processJobs()` with arrays of jobType strings to fail a new type check.  Thanks @danielparas!
+* Fixed issue introduced in 1.5.0 which caused `processJobs()` with arrays of jobType strings to fail a new type check.  Thanks @danielparas.
 
 #### 1.5.0
 

src/shared.coffee

@@ -232,6 +232,7 @@ class JobCollectionBase extends Mongo.Collection
     # Dependents: jobs that list one of the ids in their depends list
     # Antecedents: jobs with an id listed in the depends list of one of the jobs in ids
     dependsQuery = []
+    dependsIds = []
     if dependents
       dependsQuery.push
         depends:
@@ -254,8 +255,7 @@ class JobCollectionBase extends Mongo.Collection
         dependsQuery.push
           _id:
             $in: antsArray
-    if dependsQuery
-      dependsIds = []
+    if dependsQuery.length > 0
       @find(
         {
           status:

test/job_collection_tests.coffee

@@ -326,6 +326,18 @@ Tinytest.addAsync 'Dependent job saved after removed antecedent is cancelled', (
           test.isNull res, "job2.save() failed in callback result"
           onComplete()
 
+Tinytest.addAsync 'Cancel succeeds for job without deps, with using option dependents: false', (test, onComplete) ->
+  jobType = "TestJob_#{Math.round(Math.random()*1000000000)}"
+  job = new Job testColl, jobType, {}
+  job.save (err, res) ->
+    test.fail(err) if err
+    test.ok validId(res), "job.save() failed in callback result"
+    job.cancel { dependents: false }, (err, res) ->
+       console.error "Error?", err
+       test.fail(err) if err
+       test.ok res
+       onComplete()
+
 Tinytest.addAsync 'Dependent job with delayDeps is delayed', (test, onComplete) ->
   jobType = "TestJob_#{Math.round(Math.random()*1000000000)}"
   job = new Job testColl, jobType, { order: 1 }