Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added typings file for typescript projects #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added typings file for typescript projects #245

wants to merge 1 commit into from

Conversation

mibto
Copy link

@mibto mibto commented Jul 4, 2017

this file is helpful for all typescript users. I created it because i got the same error than: #232

@vsivsi
Copy link
Owner

vsivsi commented Jul 5, 2017

Hi, thanks for this. I'm not a Typescript user but just looking at it I can tell that you put a nontrivial amount of work into those declarations!

My main concern with this is that it becomes another thing that needs to be kept up-to-date as the package evolves. But there are no tests to somehow verify or flag when that may be have become an issue. (I understand that actually doing that without replicating all of the unit tests in Typescript may be difficult).

Also, this package is highly dependent on the meteor-job npm package, and a lot of what is defined here perhaps belongs there (either in addition to, or instead of here).

I don't know enough about Typescript to judge the best way to divvy the declarations up between the two packages...

@mibto
Copy link
Author

mibto commented Jul 17, 2017

Hi :)
sorry i was in holidays for 2 weeks.
i see your point about the maintenance. An other way would be that i publish the typings on https://github.com/DefinitelyTyped/DefinitelyTyped so that everybody can install and update this typing definition from there. If you like this idea more, then let me know and maybe you can add a word about it in your readme.

@vsivsi
Copy link
Owner

vsivsi commented Jul 17, 2017

At first glance, DefinitelyTyped seems like the way to go. Any drawbacks to that approach that you can think of?

@mibto
Copy link
Author

mibto commented Jul 20, 2017

sounds good for me. i'll let you know when it's done.

@pedrofg
Copy link

pedrofg commented Mar 1, 2018

Does it have a solution at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants