Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Enhance Enter Key does not work with vim o/O keys #460

Open
chiefnoah opened this issue Jul 9, 2023 · 5 comments · May be fixed by #524
Open

[BUG] Enhance Enter Key does not work with vim o/O keys #460

chiefnoah opened this issue Jul 9, 2023 · 5 comments · May be fixed by #524
Labels
bug Something isn't working

Comments

@chiefnoah
Copy link

chiefnoah commented Jul 9, 2023 •
edited
Loading

When using the vim shortcuts o or O to insert above or below the cursor, the outliner plugin does not insert a bullet point.
To Reproduce

  1. Enable vim editor layout
  2. Go to a page
  3. Press o or O (shift + o)
  4. Don't get a bullet point

Expected behavior
I think it might be best to have a separate option for it so the user can decide the behavior.

Environment (please complete the following information):
N/A
@chiefnoah chiefnoah added the bug Something isn't working label Jul 9, 2023
@chiefnoah chiefnoah changed the title [BUG] E [BUG] Enhance Enter Key does not work with vim o/O keys Jul 9, 2023
@vslinko vslinko moved this to Todo in vslinko's repos Aug 2, 2023
@RhvdG
Copy link

RhvdG commented Sep 14, 2023

I run into this bug all the time, and it would be wonderful if it were fixes (and I lack the skills to do so).

@greggroth greggroth linked a pull request May 22, 2024 that will close this issue
Open
@DivineMK
Copy link

I can't reproduce this bug. What are the conditions to reproduce it?

@greggroth
Copy link

Here's a screen recording of the reported behavior. Let me know if you have further questions on how to reproduce it

Screen.Recording.2024-06-25.at.12.47.18.PM.480.mov

@DivineMK
Copy link

Oh I see now that I already use a workaround for this, hence why I can't reproduce it 😅. I'm very sorry for wasting your time @greggroth .
In case anyone want to know the workaround: https://forum.obsidian.md/t/vim-o-and-o-should-respect-understand-current-context-lists/48386/15

@greggroth
Copy link

Thanks for sharing that! That looks way simpler and easier than what I proposed, so I'll give it shot and see if there's a way to incorporate it into my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
vslinko's repos
Status: Todo
Milestone
No milestone
4 participants
@greggroth @chiefnoah @RhvdG @DivineMK