Datapusher URL stays within docker-compose #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request changes the datapusher URL to use docker-compose style networking, so that requests to datapusher are independent of the site url.
Background
First of all - thank you for creating this incredibly well-documented way to set up CKAN. I'd been looking for a way to build a durable CKAN that was easy to reproduce, stored files on S3, and could be easily ported to a new machine without impact.
After I deployed the system following your instructions, CKAN wasn't connecting to datapusher at all. This took a long time to troubleshoot and was manifesting in 504 timeout errors every time we tried to add a new resource to a dataset and nothing entering the datastore.
Then, any resource we added that was hosted on another site was being served through the OKF Dataproxy service on Google, which frequently runs out of free bandwidth, so our data previews failed.
Anyhow, this was when it became clear that something was wrong with the datastore and the datapusher.
It appears this was also the case with prior issue #47 (datapusher isn't talking to other services)
Changes
siteurl
environment variable to connect to the datastore (which would have required the AWS security settings to open up the datapusher port), this uses docker-compose style networking to set up the datapusher connection. [e.g.CKAN_DATAPUSHER_URL: "${CKAN_SITE_URL}:8000"
->CKAN_DATAPUSHER_URL: "http://datapusher:8800"