Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pii fix #82

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Pii fix #82

merged 2 commits into from
Jan 30, 2023

Conversation

btalma
Copy link
Contributor

@btalma btalma commented Jan 30, 2023

Added check for admin token to list requests

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jan 30, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 14, PR deletions = 2

Generated by 🚫 dangerJS against c632378

@sonarqubecloud
Copy link

[vtex-apps_availability-notify-ts] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[vtex-apps_availability-notify-dotnet] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Cy-Runner

 [✓] Execution time
  -  initWorkspace................. 00:00:04
  -  installApps................... 00:00:06
  -  uninstallApps................. 00:00:03
  -  linkApp....................... 00:00:30
  -  strategy...................... 00:05:14
  -  teardown...................... 00:01:57
  -  total......................... 00:07:59

Cypress Dashboard

 [✓] https://cloud.cypress.io/projects/wnpzgv/runs/60

Success

 [✓] The test ran successfully, well done!

Copy link
Contributor

@polishq polishq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btalma btalma merged commit 5fd2459 into master Jan 30, 2023
@btalma btalma deleted the pii-fix branch January 30, 2023 14:50
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jan 30, 2023

Your PR has been merged! App is being published. 🚀
Version 1.10.0 → 1.11.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants