Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sender filter to broadcaster events. #93

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

fredppm
Copy link
Contributor

@fredppm fredppm commented Nov 22, 2023

Add a sender filter to broadcaster.notification events. + Re-add lock logs to check future opportunities.

@fredppm fredppm self-assigned this Nov 22, 2023
Copy link

vtex-io-ci-cd bot commented Nov 22, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@fredppm fredppm marked this pull request as ready for review November 22, 2023 19:00
Copy link

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.
Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 3, PR deletions = 2

Generated by 🚫 dangerJS against 267f77a

Copy link
Contributor

@eduardocesb eduardocesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@rodzac rodzac requested a review from btalma November 22, 2023 19:38
Copy link
Contributor

@btalma btalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduardocesb eduardocesb merged commit ddc611a into master Nov 22, 2023
16 of 18 checks passed
@eduardocesb eduardocesb deleted the refactory/filter_sender branch November 22, 2023 20:57
Copy link

vtex-io-ci-cd bot commented Nov 22, 2023

Your PR has been merged! App is being published. 🚀
Version 1.12.0 → 1.12.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants