Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broadcaster filter #94

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fixed broadcaster filter #94

merged 3 commits into from
Jan 24, 2024

Conversation

btalma
Copy link
Contributor

@btalma btalma commented Jan 23, 2024

Changed
"events": {
"broadcasterNotification": {
"sender": "vtex.broadcast",
"keys": [ "broadcaster.notification" ]
},
to
"events": {
"broadcasterNotification": {
"sender": "vtex.broadcaster",
"keys": [ "broadcaster.notification" ]
},

Fixed broadcaster filter
Fixed broadcaster filter
Copy link

vtex-io-ci-cd bot commented Jan 23, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 23, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 4, PR deletions = 1

Generated by 🚫 dangerJS against 76d9c8b

@btalma btalma requested a review from fredppm January 23, 2024 17:24
@btalma btalma merged commit a31f146 into master Jan 24, 2024
11 of 13 checks passed
@btalma btalma deleted the remove-filter branch January 24, 2024 19:44
Copy link

vtex-io-ci-cd bot commented Jan 24, 2024

Your PR has been merged! App is being published. 🚀
Version 1.12.1 → 1.12.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants