Fix order again button #20
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
| @@ -50,7 +49,7 @@ class OrderActions extends Component { | |||
| paymentData: { transactions }, | |||
| } = order | |||
|
|
|||
| const isOwner = email === this.state.loggedInEmail | |||
| const isOwner = email.startsWith(this.state.loggedInEmail) | |||
There was a problem hiding this comment.
How sure are we that this new email field will contain the original value as a prefix? It would be good to get a confirmation from the OMS team (if you haven't done it yet, of course). Maybe Mourão can help confirm that, if needed (I couldn't mention him here, he's probably no within this vtex-apps org yet).
There was a problem hiding this comment.
Yes, I was planning to reachout to them to understand the difference between the 2 endpoints. I will check this before merging this PR.
|
Kudos, SonarCloud Quality Gate passed!
|
|
dropped. |
What is the purpose of this pull request?
https://vtex-dev.atlassian.net/browse/B2BTEAM-1187
Due to a change on the OMS API used to retrieve order information (see: vtex-apps/b2b-organizations-graphql#124), now the
clientProfileData.emailfield returns information a bit different. Before it would return something like[email protected]and now it returns something like:[email protected].So, to decide if we should show the order again button or not, instead of using
==to compare the email strings, we check if the order email starts with the same value as the current user email.What problem is this solving?
Properly show the order again button after changing the OMS api used to retrieve order information (as the email field is returned a bit different now).
How should this be manually tested?
Install fixed versions of
b2b-organizations-graphqlandb2b-orders-historyapps, create an order and use the admin UI to complete it. After that, do the following:Access Orders (/orders-history) from My Account;
Click on Order Again;
A cart with the items from a previous order should be created (previously an error page would appear with the message "Sorry, an error occurred while processing your request.")
Screenshots or example usage
See description of: vtex-apps/b2b-organizations-graphql#124
Types of changes