feat: code review comments

vtex-apps · Dec 3, 2024 · 5214c99 · 5214c99
1 parent ba1285f
commit 5214c99
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/graphql/schema.graphql b/graphql/schema.graphql
@@ -96,6 +96,7 @@ type Query {
   getActiveOrganizationsByEmail(email: String): [B2BOrganization]
     @checkUserAccess
     @cacheControl(scope: PRIVATE)
+    @validateStoreUserAccess
 
   checkOrganizationIsActive(id: String): Boolean
     @cacheControl(scope: PRIVATE)

diff --git a/node/resolvers/Queries/Organizations.ts b/node/resolvers/Queries/Organizations.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-await-in-loop */
 import {
   ORGANIZATION_DATA_ENTITY,
   ORGANIZATION_FIELDS,
@@ -7,20 +6,14 @@ import {
   ORGANIZATION_REQUEST_SCHEMA_VERSION,
   ORGANIZATION_SCHEMA_VERSION,
 } from '../../mdSchema'
-import type { Organization } from '../../typings'
+import type {
+  GetOrganizationsByEmailWithStatus,
+  Organization,
+} from '../../typings'
 import GraphQLError, { getErrorMessage } from '../../utils/GraphQLError'
 import checkConfig from '../config'
 import { organizationStatus } from '../fieldResolvers'
 
-export interface GetOrganizationsByEmailWithStatus {
-  costId: string
-  orgId: string
-  roleId: string
-  id: string
-  clId: string
-  status: string
-}
-
 const getWhereByStatus = ({ status }: { status: string[] }) => {
   const whereArray = []
 
@@ -320,7 +313,7 @@ const Organizations = {
     } catch (error) {
       logger.error({
         error,
-        message: 'getOrganizationsByEmail-error',
+        message: 'getActiveOrganizationsByEmail-error',
       })
       throw new GraphQLError(getErrorMessage(error))
     }

diff --git a/node/typings.d.ts b/node/typings.d.ts
@@ -167,6 +167,14 @@ interface Collection {
   id: string
   name: string
 }
+interface GetOrganizationsByEmailWithStatus {
+  costId: string
+  orgId: string
+  roleId: string
+  id: string
+  clId: string
+  status: string
+}
 
 interface CostCenter {
   id: string