-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Orders client and use it to get orders info #125
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, the only concern I have here is any differences between the two endpoints, like a missing field on the endpoint we're going to use now. How sure are we that they're compatible for the use cases here?
So, I compared the 2 endpoints here: https://vtex-dev.atlassian.net/browse/B2BTEAM-1376 But yeah, is hard to say 100% that nothing will break. We don't really know if some array field that returns data in our tests, can return What do you think? PS: I talked to order-management team and they suggested this approach for now (I can give more details offline) |
I was going to suggest talking to them, but you already did! Lgtm, then! |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Use Orders endpoint instead of OMS endpoint to obtain order information. The new Orders endpoint returns the correct orderGroup (unlike the OMS endpoint) and this orderGroup is used to generate a new order when clicking on the "Order Again" button.
Ultimately this PR is fixing the KI: "Order Again from B2B Orders History doesn't work".
How to test it?
Workspace
Screenshots or example usage:
Describe alternatives you've considered, if any.