Add event trigger to deleteUser resolver

[rafael-marques]

What problem is this solving?

Using Master Data V2, we don't have a trigger to run on "delete event" like in V1. This way we can't run scripts when deleting a user. Only on adding or updating. My motivation for this is to add the ability to run scripts after a delete action.

This modification will trigger an event sending a payload containing the is and email of the deleted user.
With this, we can add an event listener and run scripts needed for that scenario

How to test it?

To test, link this branch to a workspace. Then from another app, listen to an event called b2b-organizations-graphql.removeUser

Like this: service.json

Screenshots or example usage:

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vtex-io-docs-bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

• There's nothing new to document 🤔
• I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

• I just updated 🎉🎉

[github-actions]

	Messages
📖	❤️ Thanks!
📖	🎉 PR additions = 24, PR deletions = 6

Generated by 🚫 dangerJS against 6c9e80d

[enzomerca]

LGTM, just wondering if we should add such events to other actions as well (e.g. deleteCostCenter).

Just out of curiosity, what does your script do when an user is deleted @rafael-marques ?

[rafael-marques]

Hey @enzomerca thanks for that. I believe applying that to other actions would be helpful.
Our script needs to delete the same user in a CRM we integrated with in order to sync the records, that's why we send the email in the payload.

[mairatma]

Hey @enzomerca thanks for that. I believe applying that to other actions would be helpful. Our script needs to delete the same user in a CRM we integrated with in order to sync the records, that's why we send the email in the payload.

I agree that it can be useful, but let's avoid adding more events unless they're already necessary, ok? Otherwise we'll later be in trouble if we ever need to remove the events, afraid that someone might be using them.

[mairatma]

Thanks, lgtm! Can you just rebase to fix conflicts with the master branch?

[rafael-marques]

@mairatma looks like it's already up to date with master. Where are the conflicts?

[rafael-marques]

Nvm, I've found it in the CHANGELOG and fixed it. Can you review again?

[mairatma]

@polishq I always get this kind of problem on external PRs, where one of the checks fails complaining of the missing safe to test label. I add it, but the other check removes it before the failing one can verify that it was added... Do you know how to go around this?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[polishq]

@polishq I always get this kind of problem on external PRs, where one of the checks fails complaining of the missing safe to test label. I add it, but the other check removes it before the failing one can verify that it was added... Do you know how to go around this?

@mairatma I believe it's behaving as intended. Adding the label triggers the actions to switch to the "pull_request_target" workflow (specifically for external contributions) instead of the normal "pull_request" workflow, and the label is automatically removed as part of that flow. That first security check is intended to remain "Failed" in this scenario, but the PR is still mergeable since it's not a required check.

[polishq]

LGTM

[albertm805]

LGTM

[vtex-io-ci-cd]

Your PR has been merged! App is being published. 🚀
Version 0.36.1 → 0.37.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖