Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: buyer org users metrics #128

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Sep 21, 2023

What problem is this solving?

We need to measure the B2B Suite product better to understand the behavior of merchants and buyer organizations. As described in this doc.

How to test it?

  • Access some organization in the workspace, path admin/b2b-organizations/organizations
  • Go to Users tab
  • Add an user
  • Update the same user
  • Remove the user
  • Query
select 
json_extract_path_text(json_serialize(payload), 'kind') as kind,
json_extract_path_text(json_serialize(payload), 'account') as account,
payload,
ingestion_time
FROM
    vtex.schemaless.b2b_suite_buyerorg_data_raw b2b_raw
where kind like '%user%'
and account = 'b2bsuite'

Workspace

Screenshots or example usage:

image

Related to / Depends on

The merge for this PR depends of #127.

How does this PR make you feel? 🔗

@Rudge Rudge requested a review from a team September 21, 2023 14:06
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 21, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 253, PR deletions = 58

Generated by 🚫 dangerJS against d918656

@Rudge Rudge marked this pull request as ready for review September 21, 2023 16:44
Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR is mixed with this other PR. Other than that, just some small comments.

CHANGELOG.md Outdated Show resolved Hide resolved
node/resolvers/Mutations/Organizations.ts Outdated Show resolved Hide resolved
node/typings.d.ts Outdated Show resolved Hide resolved
node/utils/metrics/metrics.ts Show resolved Hide resolved
enzomerca
enzomerca previously approved these changes Sep 25, 2023
Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

node/utils/metrics/metrics.ts Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.8% 68.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Rudge Rudge requested review from a team and enzomerca September 25, 2023 16:49
@Rudge Rudge merged commit 9f0d826 into master Sep 25, 2023
10 checks passed
@Rudge Rudge deleted the feature/B2BTEAM-1255-buyer-org-users-metrics branch September 25, 2023 17:35
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 25, 2023

Your PR has been merged! App is being published. 🚀
Version 0.38.0 → 0.39.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants