-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paymentTerms
field when creating a cost center.
#164
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
@rayssamfreitas Could you update the changelog, please? |
@Rudge , updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We are going to merge/deploy it soon.
Upon further review, we believe this PR would cause the incorrect usage of a feature. There is a feature that allows the Buyer Org Admin to enable/disable payment terms for a given cost center through the "My Account" section on the storefront. The cost center payment terms field, that can be updated through the updateCostCenter, should be used exclusively for that. Could you please explain your use case so we can evaluate if this change makes sense or if there is an alternative way to achieve your needs? |
paymentTerms
field when creating an organization.paymentTerms
field when creating a cost center.
Discussed offline, but it actually makes sense to add this parameter to the |
Quality Gate passedIssues Measures |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Adjusts to send the
paymentTerms
field when creating an organization.How to test it?
You can test by creating an organization and also passing a
paymentTerms
.Workspace
Screenshots or example usage: