Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paymentTerms field when creating a cost center. #164

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

rayssamfreitas
Copy link
Contributor

What problem is this solving?

Adjusts to send the paymentTerms field when creating an organization.

How to test it?

You can test by creating an organization and also passing a paymentTerms.

Workspace

Screenshots or example usage:

Captura de tela 2024-07-04 174226

Copy link

vtex-io-ci-cd bot commented Jul 4, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 4, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Jul 8, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 7, PR deletions = 0

Generated by 🚫 dangerJS against 9349f10

@Rudge
Copy link
Contributor

Rudge commented Jul 8, 2024

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

* `Added` for new features.

* `Changed` for changes in existing functionality.

* `Deprecated` for soon-to-be removed features.

* `Removed` for now removed features.

* `Fixed` for any bug fixes.

* `Security` in case of vulnerabilities.

Warnings
⚠️

package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]
Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 5, PR deletions = 2

Generated by 🚫 dangerJS against 28d5ad6

@rayssamfreitas Could you update the changelog, please?

@rayssamfreitas
Copy link
Contributor Author

@Rudge , updated!

enzomerca
enzomerca previously approved these changes Jul 15, 2024
Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are going to merge/deploy it soon.

@enzomerca enzomerca self-requested a review July 31, 2024 12:05
@enzomerca
Copy link
Contributor

Upon further review, we believe this PR would cause the incorrect usage of a feature.

There is a feature that allows the Buyer Org Admin to enable/disable payment terms for a given cost center through the "My Account" section on the storefront. The cost center payment terms field, that can be updated through the updateCostCenter, should be used exclusively for that.
The misuse of this feature could cause unexpected behaviour when adding new payment terms to an existing buyer org through the Admin UI.

Could you please explain your use case so we can evaluate if this change makes sense or if there is an alternative way to achieve your needs?

@enzomerca enzomerca changed the title Add paymentTerms field when creating an organization. Add paymentTerms field when creating a cost center. Aug 1, 2024
@enzomerca
Copy link
Contributor

Discussed offline, but it actually makes sense to add this parameter to the createCostCenter APIs.
The PR description/changelog info was saying organization but this change does not affect the createOrganization API.
I updated the PR description and changelog and I'm going to merge/deploy this change.

enzomerca
enzomerca previously approved these changes Aug 6, 2024
Copy link

sonarqubecloud bot commented Aug 6, 2024

@enzomerca enzomerca merged commit a84bd07 into vtex-apps:master Aug 6, 2024
20 of 21 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 6, 2024

Your PR has been merged! App is being published. 🚀
Version 0.52.0 → 0.53.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants