Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add permission org #169

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

giurigaud
Copy link
Contributor

@giurigaud giurigaud commented Aug 1, 2024

What problem is this solving?

Allow the quotes functionality to be configurable through the Admin Panel, offering the user the possibility to enable or disable the functionality in their Store/Organization.

How to test it?

Call the following methods:
updateOrganization
getOrganizationById
getOrganization
getOrganizationByIdStorefront

Workspace

Screenshots or example usage:

Screenshot 2024-08-01 at 08 24 02 #### Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Aug 1, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@enzomerca enzomerca requested a review from a team September 2, 2024 12:27
Copy link
Contributor

@ataideverton ataideverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

enzomerca
enzomerca previously approved these changes Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 79, PR deletions = 16

Generated by 🚫 dangerJS against 8803e23

@enzomerca
Copy link
Contributor

Fails
🚫
This PR will change tooling [:bulb: add #changingTooling on your description as ack to pass]

Warnings
⚠️
package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]

Messages
📖 ❤️ Thanks!
📖
🎉 PR additions = 75, PR deletions = 17

Generated by 🚫 dangerJS against 6e1bcd8

I see the package.json file was not changed at all but is included in the commit, and the quality check is failing because of this. Can you remove the package.json from the commit please?

@ataideverton ataideverton force-pushed the feat/add-permission-org branch from ece790c to 8803e23 Compare October 8, 2024 03:23
Copy link

sonarqubecloud bot commented Oct 8, 2024

@ataideverton ataideverton merged commit e29522a into vtex-apps:master Oct 8, 2024
20 of 21 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 8, 2024

Your PR has been merged! App is being published. 🚀
Version 0.58.0 → 0.59.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants