Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getAccount query to retrieve account information #171

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

icaroov
Copy link
Contributor

@icaroov icaroov commented Aug 28, 2024

What problem is this solving?

There is a discrepancy between the name used in the product search and the name displayed in the B2B suite. The search uses the "trade name" registered in Account Management, while the B2B suite uses the "seller name" defined in Seller Management. This difference in naming can result in an inconsistent display of available products, since the search may not return products if the names registered in the two modules differ.

To resolve this issue and align the user experience, it was necessary to adjust the B2B suite to use the "trade name" from Account Management instead of the "seller name" from Seller Management. This will ensure that products are displayed correctly in the search and in the B2B suite interface, regardless of the name registered in Seller Management.

To achieve this, a new query getAccount was created to retrieve account data and use it when assigning a salesperson to an organization.

How to test it?

query GetAccount {
  getAccount {
    id
    name
    accountName
    tradingName
    isActive
  }
}

Workspace

How does this PR make you feel? 🔗

This commit adds a new `getAccount` query to retrieve account information. It includes fields such as `id`, `name`, `accountName`, `tradingName`, and `isActive`. This query is implemented in both the GraphQL schema and the LMClient class.
Copy link

vtex-io-ci-cd bot commented Aug 28, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Sep 3, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 80, PR deletions = 0

Generated by 🚫 dangerJS against a7ad510

graphql/schema.graphql Outdated Show resolved Hide resolved
@icaroov icaroov requested a review from enzomerca September 3, 2024 17:02
Copy link

sonarqubecloud bot commented Sep 3, 2024

@enzomerca enzomerca merged commit 1b7f76d into vtex-apps:master Sep 9, 2024
12 checks passed
Copy link

vtex-io-ci-cd bot commented Sep 9, 2024

Your PR has been merged! App is being published. 🚀
Version 0.55.0 → 0.56.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants