Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/organizations search criteria #186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Josmar-jr
Copy link
Contributor

PR Description

What problem is this solving?

This PR addresses two key updates to improve the user experience in the Organizations module:

  1. The placeholder text in the search input has been updated from "Search" to "Search for ID, trade name or legal name", making the purpose of the search field clearer.
  2. The generic alert for unavailable "Trade Name" search functionality has been replaced with a contextual error message:
    "The 'Trade Name' search feature is disabled for this account. To enable the search, please set the 'Trade Name' field as 'Is Filterable' in the Masterdata."

These changes aim to align the interface with user expectations and reduce confusion while navigating the Organizations search.

How to test it?

  1. Go to the Organizations module in the linked workspace.
  2. Verify that the placeholder in the search input reflects the new text:
    "Search for ID, trade name or legal name".
  3. Trigger the error by attempting to search with a disabled "Trade Name" feature. Confirm the error message matches the provided description.

[Workspace](Link goes here!)

Screenshots or example usage:

Screen.Recording.2024-11-19.at.10.42.41.mov

Describe alternatives you've considered, if any.

Related to / Depends on

  • Task: Organizations Search Criteria Preparation

How does this PR make you feel? [🔗](https://i.giphy.com/media/v1.Y2lkPTc5MGI3NjExZzdmdW5kNXo2bmM5ZzgxODVkNzE1OG1rczEybGdsM3A2b2VkeXdhZiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/ZubZqIeSsZ60t0ID9l/giphy-downsized-large.gif)

![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented Nov 19, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant