Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token validation and set token in graphql clients #45

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Dec 11, 2023

What problem is this solving?

We found some apps that don't pass the token to call graphql queries or mutations. So we need a guarantee to have all integrations send the token, and we will block unauthenticated requests from the app provider.

Workspace

Copy link

vtex-io-ci-cd bot commented Dec 11, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Dec 11, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 219, PR deletions = 145

Generated by 🚫 dangerJS against a44a641

@Rudge Rudge requested a review from a team December 13, 2023 13:21
@Rudge Rudge marked this pull request as ready for review December 13, 2023 13:21
Copy link

@Rudge Rudge merged commit b0fd132 into master Dec 15, 2023
13 checks passed
@Rudge Rudge deleted the feature/B2BTEAM-1286-add-token-validation branch December 15, 2023 12:12
Copy link

vtex-io-ci-cd bot commented Dec 15, 2023

Your PR has been merged! App is being published. 🚀
Version 2.4.1 → 2.5.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants