Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: get quote enabled for user query #51

Merged

Conversation

enzomerca
Copy link
Contributor

@enzomerca enzomerca commented Aug 26, 2024

What problem is this solving?

Currently, frontend (b2b-quotes) calls the getUserByEmail API from b2b-organizations-graphql app to check if the user is part of a buyer org and, if it is, show the "My Quotes" button on "My Account" page.
The getUserByEmail API returns much more stuff than necessary. Instead, now we have a much simpler query with restricted info on the b2b-quotes-graphql app, which should be faster, less error prone, and will also simplify overall B2B Suite code.

Related PR on b2b-quotes which will use this new API: vtex-apps/b2b-quotes#62

Copy link

vtex-io-ci-cd bot commented Aug 26, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 26, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 58, PR deletions = 0

Generated by 🚫 dangerJS against b31b13d

Copy link

sonarqubecloud bot commented Sep 2, 2024

@enzomerca enzomerca merged commit 5e2fa54 into master Sep 4, 2024
23 checks passed
@enzomerca enzomerca deleted the fix/B2BTEAM-1833-add-get-quote-enabled-for-user-query branch September 4, 2024 13:09
Copy link

vtex-io-ci-cd bot commented Sep 4, 2024

Your PR has been merged! App is being published. 🚀
Version 2.5.4 → 2.5.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@enzomerca
Copy link
Contributor Author

Actual version that was manually generated for this PR:

10:34:20.454 - info: [email protected] was published successfully!  
10:34:20.455 - info: You can deploy it with: vtex deploy [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants