Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set viewedByCustomer is false, where is null #54

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix: Set viewedByCustomer is false, where is null #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff97921
Set viewedByCustomer is false, where is null
pabloppupulin Oct 29, 2024
90e052e
Add Changelog
pabloppupulin Oct 29, 2024
8cb2ab9
Fix LINT
pabloppupulin Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Set viewedByCustomer value False when value is null

## [2.6.2] - 2024-10-02

### Added
Expand Down
4 changes: 2 additions & 2 deletions node/resolvers/mutations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ export const Mutation = {
status,
subtotal: subtotal ?? existingQuote.subtotal,
updateHistory,
viewedByCustomer: decline || isCustomer,
viewedBySales: decline || isSales,
viewedByCustomer: !!(decline || isCustomer),
viewedBySales: !!(decline || isSales),
}

const data = await masterdata
Expand Down
4 changes: 4 additions & 0 deletions node/utils/Queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ const processItem = ({ ctx, item }: { ctx: Context; item: Quote }) => {
return
}

if (item.viewedByCustomer === null) {
item.viewedByCustomer = false
}

const status = 'expired'
const now = new Date()
const nowISO = now.toISOString()
Expand Down
Loading