[Seller Quotes] feat: verify if seller accepts quotes to process splitting and notify #59

tiago-freire · 2024-12-11T13:37:33Z

What problem is this solving?

Calls b2b-seller-quotes to verify if seller accepts quotes and to notify when a new quote is created.

How to test it?

Clone branch feat/verify-and-notify-quotes-endpoints of b2b-seller-quotes an execute pnpm dev:vtex
Clone the branch of this PR, switch to bravtexfashionb2b account and link b2b-quotes-graphql on workspace b2bsellerquoteslocalhost (the same workspace name generated by pnp:dev:vtex on b2b-seller-quotes in the indicated branch of previous step)
Create a quote that contains product of seller shopfashion568: https://b2bsellerquoteslocalhost--bravtexfashionb2b.myvtex.com/camisa-feminina-gray/p
Observe the server logs of b2b-seller-quotes, where there should be 2 received requests:
- /b2b-seller-quotes/_v/0/verify-quote-settings
- /b2b-seller-quotes/_v/0/notify-new-quote

Workspace

…tex/b2b-quotes-graphql into feat/splitting-quote-by-seller

…er only parent quotes

…x/b2b-quotes-graphql into feat/notify-seller-quote

vtex-io-ci-cd · 2024-12-11T13:37:37Z

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

Patch (backwards-compatible bug fixes)
Minor (backwards-compatible functionality)
Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

No thanks, I would rather do it manually 😞

vtex-io-docs-bot · 2024-12-11T13:37:46Z

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

There's nothing new to document 🤔
I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

I just updated 🎉🎉

tiago-freire · 2024-12-11T13:41:32Z

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

Patch (backwards-compatible bug fixes)

Minor (backwards-compatible functionality)

Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

No thanks, I would rather do it manually 😞

tiago-freire · 2024-12-11T13:41:48Z

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

There's nothing new to document 🤔

I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

I just updated 🎉🎉

…tex/b2b-quotes-graphql into feat/notify-seller-quote

…ller

…quotes-graphql into feat/notify-seller-quote

Matheus-Aguilar · 2024-12-17T20:19:58Z

graphql/quote.graphql

@@ -59,6 +59,10 @@ type Quote {
  viewedBySales: Boolean
  viewedByCustomer: Boolean
  salesChannel: String
+  seller: String
+  approvedBySeller: Boolean
+  parentQuote: String


After the split, all quotes are independent. So there is no need to keep a parent quote or children data.

Without a link between the sellers quotes and the "parent" quote, it would not be possible to create this screen, for example: https://www.figma.com/design/SDETDCU5obc4Kg4WtmG6FH/RedCloud-%C2%B7-Seller-Quotes-%5BCubos%5D?node-id=263-24328&t=daYlrwPapSKRVfZN-4.

The where assembly that brings the quotes at marketplace side was changed because of this, always adding parentQuote is null in searches: https://github.com/vtex-apps/b2b-quotes-graphql/pull/59/files#diff-9766252b6f3131ecfc785f3869d3129273b19c4a91b52963b62c5d3803c964d7

The "link" between the quotes should be just a name or label and not a parent quote. It's name displayed in this screen

a relationship based on a string that is input by the user?

Matheus-Aguilar · 2024-12-17T20:21:48Z

graphql/quote.graphql

@@ -59,6 +59,10 @@ type Quote {
  viewedBySales: Boolean
  viewedByCustomer: Boolean
  salesChannel: String
+  seller: String
+  approvedBySeller: Boolean


There is no need to have a field only for the seller's approval. A seller quote should use the same status as a regular quote. The only additional information is the seller's name, so you can query this information later.

We understand that once the seller accepts the quote, there is no need to make the request to the seller again. approvedBySeller starts with false when the seller is notified and can become true depending on their approval. The first time the marketplace requests this data, it can save it so that it does not need to be requested again if the seller has approved the quote.

On second thought, i think you are right. We can just use the status for seller approval control.

Done at f6a1117

node/metrics/createQuote.ts

Matheus-Aguilar · 2024-12-17T20:42:50Z

node/resolvers/mutations/index.ts

-        email,
+      const parentQuoteItems = hasSellerQuotes
+        ? items.filter(
+            (item) =>


Isn't there a more efficient way of doing this filtering? Like, filter all items with seller === '1' (opposite of the previous filter)?

No, because there may be a seller in the quote items who:

does not have b2b-seller-quotes installed

does have b2b-seller-quotes installed, but has the setting to not accept quotes

In these cases, these quote items remains under the management of the marketplace.

Matheus-Aguilar · 2024-12-17T20:44:00Z

node/resolvers/mutations/index.ts

+      //       subtotal
+      //     )
+      //   : subtotal
+      const parentQuote = createQuoteObject({


If there are no items from the marketplace, the parent quote should not be created.

There needs to be a link between the sellers quotes and the "parent" quote, as we said in these comment.

Matheus-Aguilar · 2024-12-18T14:33:24Z

node/resolvers/utils/checkConfig.ts

@@ -345,7 +352,10 @@ export const checkConfig = async (ctx: Context) => {
    return null
  }

-  if (!settings?.adminSetup?.cartLifeSpan) {
+  if (


Shouldn't this check be an OR instead of an AND?

This is a check to return to the default settings if no setting is filled in yet. Therefore, it has to be AND.

Matheus-Aguilar · 2024-12-18T14:43:48Z

node/resolvers/utils/quotes.ts

+    })
+
+  // The ternary check is to not request again from the same seller
+  const verifyResponse = quoteBySeller[seller]


I think many calls would still be made if there was a seller who does not accept quotes with multiple items, since it would not be included in the quoteBySeller map.

makes sense. let's analyze this.

Matheus-Aguilar · 2024-12-18T14:45:12Z

node/resolvers/utils/quotes.ts

+  const { seller } = item
+
+  const next = async () =>
+    splitItemsBySeller({


Is a recursive approach really necessary here? I think that an iterative approach would be simpler and more efficient.

https://eslint.org/docs/latest/rules/no-await-in-loop

brunass and others added 16 commits November 26, 2024 14:09

feat: add new markeplace splitting quotes on graphql

344c77f

feat: checking new field quotesManagedBy when value is SELLER

a9ece27

docs: update CHANGELOG

d40f705

feat: add configuration for quote creation

58ff10b

feat: add adjustment for quote seller

3cae023

chore: fix prettier errors

df48022

fix: returning ids separated by commas when multiple quotes

85622cb

fix: check config and default settings with marketplace option

b3a2c6c

Merge branch 'quotes-b2b-marketplace-splitting' of github.com:cubos-v…

b3450d2

…tex/b2b-quotes-graphql into feat/splitting-quote-by-seller

feat: new fields for quotes managed by seller

ffeadeb

feat: new fields to save parent quote; change getQuotes query to filt…

1d8b309

…er only parent quotes

feat: create client to notify seller quote

3613262

feat: add changelog

f81db01

feat: verify and notify seller quote

9af7ee0

chore: removes console.log from SellerQuotesClient

caccc46

Merge branch 'feat/splitting-quote-by-seller' of github.com:cubos-vte…

5c5771f

…x/b2b-quotes-graphql into feat/notify-seller-quote

docs: update CHANGELOG and prettier fix on markdown

34901e0

tiago-freire changed the title ~~[Seller Quotes] feat: verify if seller accepts quotes and notify seller with quote as payload~~ [Seller Quotes] feat: verify if seller accepts quotes to process splitting and notify Dec 14, 2024

tiago-freire and others added 6 commits December 14, 2024 20:20

fix: right splitting of seller quotes

70d1c4d

Merge branch 'quotes-b2b-marketplace-splitting' of github.com:cubos-v…

e2730f8

…tex/b2b-quotes-graphql into feat/notify-seller-quote

feat: refactor on creating seller quote map; avoid double check of se…

69d2076

…ller

Merge branch 'feat/notify-seller-quote' of github.com:cubos-vtex/b2b-…

92ef22e

…quotes-graphql into feat/notify-seller-quote

refactor: seller quotes client constants

fbb6529

feat: send creationDate on notify seller quote

021b359

Matheus-Aguilar reviewed Dec 17, 2024

View reviewed changes

node/metrics/createQuote.ts Show resolved Hide resolved

Matheus-Aguilar reviewed Dec 17, 2024

View reviewed changes

fix: removing approvedBySeller field from quote entity

f6a1117

Matheus-Aguilar reviewed Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Seller Quotes] feat: verify if seller accepts quotes to process splitting and notify #59

[Seller Quotes] feat: verify if seller accepts quotes to process splitting and notify #59

tiago-freire commented Dec 11, 2024 •

edited

Loading

vtex-io-ci-cd bot commented Dec 11, 2024

vtex-io-docs-bot bot commented Dec 11, 2024

tiago-freire commented Dec 11, 2024

tiago-freire commented Dec 11, 2024

Matheus-Aguilar Dec 17, 2024 •

edited

Loading

tiago-freire Dec 17, 2024

tiago-freire Dec 17, 2024

Matheus-Aguilar Dec 18, 2024

tiago-freire Dec 18, 2024

Matheus-Aguilar Dec 17, 2024

tiago-freire Dec 17, 2024

tiago-freire Dec 17, 2024

tiago-freire Dec 17, 2024

Matheus-Aguilar Dec 17, 2024

tiago-freire Dec 17, 2024 •

edited

Loading

Matheus-Aguilar Dec 17, 2024

tiago-freire Dec 17, 2024

Matheus-Aguilar Dec 18, 2024

tiago-freire Dec 18, 2024

Matheus-Aguilar Dec 18, 2024

tiago-freire Dec 18, 2024

Matheus-Aguilar Dec 18, 2024

tiago-freire Dec 18, 2024

[Seller Quotes] feat: verify if seller accepts quotes to process splitting and notify #59

Are you sure you want to change the base?

[Seller Quotes] feat: verify if seller accepts quotes to process splitting and notify #59

Conversation

tiago-freire commented Dec 11, 2024 • edited Loading

What problem is this solving?

How to test it?

vtex-io-ci-cd bot commented Dec 11, 2024

vtex-io-docs-bot bot commented Dec 11, 2024

tiago-freire commented Dec 11, 2024

tiago-freire commented Dec 11, 2024

Matheus-Aguilar Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tiago-freire Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tiago-freire commented Dec 11, 2024 •

edited

Loading

Matheus-Aguilar Dec 17, 2024 •

edited

Loading

tiago-freire Dec 17, 2024 •

edited

Loading