Fix the IDs for headers

vtex-apps · Jul 29, 2019 · 60aa9cd · 60aa9cd
1 parent 8c18636
commit 60aa9cd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/react/components/CustomTags.tsx b/react/components/CustomTags.tsx
@@ -45,7 +45,7 @@ export const CustomRenderers = {
   },
   emphasis: (props: any) => <em className="i">{props.children}</em>,
   heading: (props: any) => {
-    const hashId = slug(props.children)
+    const hashId = getHeadingSlug(props.children)
 
     switch (props.level) {
       case 1:
@@ -169,3 +169,9 @@ export const CustomRenderers = {
   tableRow: (props: any) => <tr className="bb b--muted-3">{props.children}</tr>,
   thematicBreak: () => <hr className="mv7" />,
 }
+
+function getHeadingSlug(childNodes: any) {
+  return (
+    (childNodes[0].props.children && slug(childNodes[0].props.children)) || ''
+  )
+}
diff --git a/react/utils/index.ts b/react/utils/index.ts
@@ -1,8 +1,8 @@
 import slugify from 'slugify'
 
-function slug(str?: string | Record<string, any>) {
+function slug(str: string) {
   const replaced =
-    (str && str.toString().replace(/[*+~.()'"!:@&[\]]/g, '')) || ''
+    (typeof str === 'string' && str.replace(/[*+~.()'"!:@&[\]]/g, '')) || ''
   const slugified = slugify(replaced, { lower: true }) || ''
   return slugified
 }