wip: easypost integration #175
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
ghost
requested a review
from 
There was a problem hiding this comment.
@edyespinal @zekivtex Nice work! I added a couple of suggestions. Also, I didn't see anything on the store side. I think it would be nice to allow the store user to see the label in the interface.
react/admin/ReturnDetails/components/ReturnLabel/ReturnLabel.tsx
Outdated
Show resolved
Hide resolved
react/admin/ReturnDetails/components/ReturnLabel/ReturnLabel.tsx
Outdated
Show resolved
Hide resolved
react/admin/ReturnDetails/components/ReturnLabel/ReturnLabel.tsx
Outdated
Show resolved
Hide resolved
react/admin/ReturnDetails/components/ReturnLabel/ReturnLabel.tsx
Outdated
Show resolved
Hide resolved
react/admin/ReturnDetails/components/ReturnLabel/ReturnLabel.tsx
Outdated
Show resolved
Hide resolved
| @@ -110,7 +111,7 @@ type PickupReturnData { | |||
| country: String! | |||
| zipCode: String! | |||
| addressType: AddressType! | |||
| returnLabel: String | |||
| labelUrl: String | |||
There was a problem hiding this comment.
This key coming from MD and mapped on schema.json under masterdata builder is called returnLabel. In order to be consistent we should either change how we are saving it on masterdata or how we are declaring it on schema. I think the first one is the preferred one since, since changing schema on md can have side effects in the indexation process.
| app: { settings }, | ||
| } = installedApp | ||
|
|
||
| const { street1, street2, city, state, zip, country, name, phone } = |
There was a problem hiding this comment.
Should we check if the settings has value? What does it return when the app is not installed?
What problem is this solving?
Integration with easypost in order to create a return label.
How to test it?
Workspace
@edyespinal I couldn't tag you because you are a participant. Please take a look if you have time