Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Taxes to Surcharges to better reflect actual functionality #224

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

kaio-donadelli
Copy link
Contributor

@kaio-donadelli kaio-donadelli commented Jun 5, 2024

What is the purpose of this pull request?

Tracked in task LOC-11675. Following a discussion with the Pricing and Promotions team, we agreed upon a terminology update, changing "tax"to "surcharge" when the string does not specifically refer to government taxes, but to any surcharge our clients might want to add to a product.

Copy link

vtex-io-ci-cd bot commented Jun 5, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jun 5, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@kaio-donadelli kaio-donadelli requested review from filafb, Git-the-Sanz and sheilagomes and removed request for filafb June 5, 2024 11:04
Copy link
Contributor

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaio-donadelli kaio-donadelli merged commit b168961 into main Aug 8, 2024
4 of 5 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 8, 2024

Your PR has been merged! App is being published. 🚀
Version 3.10.2 → 3.10.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants