Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENGINEERS-1070] - Verifying Reviews are sorted By DateTime using Xls doc #240

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[ENGINEERS-1070] - Verifying Reviews are sorted By DateTime using Xls doc #240

wants to merge 9 commits into from

Conversation

sumanraj123
Copy link
Contributor

@sumanraj123 sumanraj123 commented Jan 14, 2023 •
edited
Loading

Verify reviews are sorted by dateTime
Improved selectors and sorting
#changingTooling

@sumanraj123 sumanraj123 requested a review from a team as a code owner January 14, 2023 12:01
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jan 14, 2023 •
edited by thyarles
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 14, 2023 •
edited by thyarles
Loading

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@github-actions
Copy link

github-actions bot commented Jan 14, 2023 •
edited
Loading

Warnings
⚠️

🛑 This PR will change tooling [💡 could be GitHub Actions, package.json, etc]
Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 104, PR deletions = 27

Generated by 🚫 dangerJS against 9d49535

thyarles
thyarles previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@thyarles thyarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thyarles
thyarles previously approved these changes Jan 18, 2023
View reviewed changes
Syed-Vtex
Syed-Vtex suggested changes Jan 18, 2023
View reviewed changes
cypress/support/selectors.js Outdated
@@ -35,4 +35,11 @@ export default {
GetReviewByIndex: index => {
return `div[class*=reviewCommentsContainer] div[class*=reviewComment]:nth-child(${index}) div[class*=reviewCommentRating] span[class*=filled]`
},
Download: 'div[class*=pal] > .vtex-button]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this selector(div[class*=pal] > .vtex-button]) working fine ? because it has close ] not open [

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

[vtex-apps_reviews-and-ratings-ts] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[vtex-apps_reviews-and-ratings-dotnet] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Syed-Vtex Syed-Vtex changed the title Verifying Reviews are sorted By DateTime using Xls doc [ENGINEERS-1070] - Verifying Reviews are sorted By DateTime using Xls doc Jan 18, 2023
@github-actions
Copy link

Cy-Runner

 [✓] Execution time
  -  initWorkspace................. 00:00:04
  -  installApps................... 00:00:00
  -  uninstallApps................. 00:00:00
  -  linkApp....................... 00:00:40
  -  strategy...................... 00:10:22
  -  teardown...................... 00:00:15
  -  total......................... 00:11:25

Cypress Dashboard

 [✓] https://cloud.cypress.io/projects/964exx/runs/350

Success

 [✓] The test ran successfully, well done!

thyarles
thyarles approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@thyarles thyarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syed-Vtex Syed-Vtex Syed-Vtex requested changes

@thyarles thyarles thyarles approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumanraj123 @thyarles @Syed-Vtex @sumanbitcot