Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infix wildcard #253

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Remove infix wildcard #253

merged 1 commit into from
Nov 16, 2023

Conversation

jumc
Copy link
Collaborator

@jumc jumc commented Nov 16, 2023

What problem is this solving?

This app currently represents ~78% of wildcard queries at Master Data and it uses inffix *{value}* queries unnecessarily. Suffix wildcards are less expensive to calculate.

Copy link

vtex-io-ci-cd bot commented Nov 16, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 16, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@jumc jumc requested a review from btalma November 16, 2023 17:34
@jumc jumc self-assigned this Nov 16, 2023
Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 5, PR deletions = 2

Generated by 🚫 dangerJS against 03cd5dd

Copy link
Contributor

@btalma btalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GustavoMA GustavoMA changed the title Remove prefix wildcard Remove infix wildcard Nov 16, 2023
@polishq polishq merged commit 738748d into master Nov 16, 2023
7 of 9 checks passed
@polishq polishq deleted the remove-masterdata-prefix-wildcard branch November 16, 2023 18:47
Copy link

vtex-io-ci-cd bot commented Nov 16, 2023

Your PR has been merged! App is being published. 🚀
Version 3.13.2 → 3.13.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants