Wildcard locales as fallback #254
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
| @@ -413,13 +414,23 @@ public async Task<ReviewsResponseWrapper> GetReviewsByProductId(string productId | |||
|
|
|||
| AppSettings settings = await GetAppSettings(); | |||
|
|
|||
| if (pastRevNLocale) | |||
| if (Locale.localeList.ContainsKey(locale)) | |||
There was a problem hiding this comment.
Need to check for null or empty locale
if (!string.IsNullOrEmpty(locale) && Locale.localeList.ContainsKey(locale))
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Wildcard queries are expensive to process at Masterdata. Since locales are finite and defined at ISO-639-1 and country codes too (for ISO-3166-1) we are able to use locale values statically and change the wildcard query to
OR.We'll keep the wildcard as fallback.