Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: save approved review #266

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Feat: save approved review #266

merged 3 commits into from
Jan 29, 2025

Conversation

lariciamota
Copy link
Contributor

@lariciamota lariciamota commented Jan 29, 2025

What problem is this solving?

The approved info on the request body for creating a new review was being ignored, so even when it was sent as true the review was being saved as false.

How to test it?

Workspace laricia

Through the /review route: POST https://laricia--storeframework.myvtex.com/reviews-and-ratings/api/review
Body with approved as true:

{
    "productId": "21395412",
    "rating": 4,
    "title": "Review Title",
    "text": "Review Text",
    "reviewerName": "Reviewer Name",
    "approved": true
}

⚠️ Remember to use the header VtexIdclientAutCookie with your token when testing the route.

Screenshots or example usage:

Sending the POST req:
Screenshot 2025-01-29 at 15 33 59
Checking that it was saved as true:
Screenshot 2025-01-29 at 15 34 18

Ref

@lariciamota lariciamota self-assigned this Jan 29, 2025
Copy link

vtex-io-ci-cd bot commented Jan 29, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sorry, something went wrong.

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 29, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sorry, something went wrong.

eduardoformiga
eduardoformiga previously approved these changes Jan 29, 2025
@lariciamota lariciamota force-pushed the feat/save-approved-review branch from 62835d1 to 4b51099 Compare January 29, 2025 18:50
@lariciamota lariciamota changed the base branch from feat/adds-stars-to-rating-response to master January 29, 2025 18:50
@lariciamota lariciamota dismissed eduardoformiga’s stale review January 29, 2025 18:50

The base branch was changed.

Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 6, PR deletions = 1

Generated by 🚫 dangerJS against 7ee8160

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@wender wender merged commit 7efb062 into master Jan 29, 2025
2 of 3 checks passed
@wender wender deleted the feat/save-approved-review branch January 29, 2025 19:31
Copy link

vtex-io-ci-cd bot commented Jan 29, 2025

Your PR has been merged! App is being published. 🚀
Version 3.16.1 → 3.17.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants