-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add popover to delivery button #10
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changelog entry
react/package.json
Outdated
"@types/node": "^13.9.8", | ||
"@types/react": "^18.3.3", | ||
"@types/react": "^18.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we on react 18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are. I needed to change the version of @types/react because I had some problems adding the react-outside-click-handler library. The solution I found is to use the same version of react in @types/react.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in main to confirm if it was caused by any of my changes but in main it is also occurring. I have no idea why this is like this, maybe @hiagolcm has a clue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have. I would need to investigate. But since it is just the @types we can just change it to the 16.x
But this issue should be addressed in another PR
feat: add input in popover to define postal code
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
This Pr adds a popover to location button
card: IS-5655
How to test it?
Open the page and a popover should open
Workspace
Screenshots or example usage:
Gravacao.de.Tela.2024-11-22.as.12.18.59.mov
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗