Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add popover to delivery button #10

Merged
merged 18 commits into from
Dec 18, 2024
Merged

Conversation

ArthurFerrao
Copy link
Contributor

@ArthurFerrao ArthurFerrao commented Nov 22, 2024

What problem is this solving?

This Pr adds a popover to location button
card: IS-5655

How to test it?

Open the page and a popover should open

Workspace

Screenshots or example usage:

Gravacao.de.Tela.2024-11-22.as.12.18.59.mov

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

@ArthurFerrao ArthurFerrao added the enhancement New feature or request label Nov 22, 2024
@ArthurFerrao ArthurFerrao self-assigned this Nov 22, 2024
@ArthurFerrao ArthurFerrao requested a review from a team as a code owner November 22, 2024 15:22
Copy link

vtex-io-ci-cd bot commented Nov 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 22, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

@salesfelipe salesfelipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry

"@types/node": "^13.9.8",
"@types/react": "^18.3.3",
"@types/react": "^18.3.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we on react 18?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are. I needed to change the version of @types/react because I had some problems adding the react-outside-click-handler library. The solution I found is to use the same version of react in @types/react.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I don't think we are on version 18, but rather on 16, vide:

Screenshot 2024-11-22 at 14 30 34

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in main to confirm if it was caused by any of my changes but in main it is also occurring. I have no idea why this is like this, maybe @hiagolcm has a clue.

Copy link
Collaborator

@hiagolcm hiagolcm Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have. I would need to investigate. But since it is just the @types we can just change it to the 16.x

But this issue should be addressed in another PR

Copy link

github-actions bot commented Dec 17, 2024

Fails
🚫

Please remove the line ## [0.4.2] - 2024-11-06 from CHANGELOG.md
This will be automatically added once this PR is merged.

Generated by 🚫 dangerJS against efb0009

@ArthurFerrao ArthurFerrao merged commit 49c16ce into main Dec 18, 2024
7 of 8 checks passed
Copy link

vtex-io-ci-cd bot commented Dec 18, 2024

Your PR has been merged! App is being published. 🚀
Version 0.4.2 → 0.5.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants