Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shipping_info cookie #12

Merged
merged 2 commits into from
Dec 19, 2024
Merged

add shipping_info cookie #12

merged 2 commits into from
Dec 19, 2024

Conversation

hiagolcm
Copy link
Collaborator

What problem is this solving?

Currently we use the __RUNTIME__.segmentToken to get the last shipping information selected by the user. Unfortunately, this source is not reliable and might be outdated. For this reason, this PR adds the shipping_info cookie to be the primary source for the shipping information.

How to test it?

Workspace

Copy link

vtex-io-ci-cd bot commented Dec 18, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 18, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hiagolcm hiagolcm force-pushed the bugfix/zipcode-is-not-updated branch from 6aa8005 to 327253e Compare December 18, 2024 18:38
@hiagolcm hiagolcm self-assigned this Dec 18, 2024
Copy link
Contributor

@ArthurFerrao ArthurFerrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiagolcm hiagolcm merged commit 75f974e into main Dec 19, 2024
10 checks passed
Copy link

vtex-io-ci-cd bot commented Dec 19, 2024

Your PR has been merged! App is being published. 🚀
Version 0.5.0 → 0.5.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants