Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hideStoreSelection just hides the button #15

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

ArthurFerrao
Copy link
Contributor

What problem is this solving?

The hideStoreSelection property hides the pickup drawer and when the pickup facet is clicked, the drawer does not work. This PR changes this behavior to just hide the button in the header and the drawer can be opened with the facet.

How to test it?

Add the hideStoreSelection property in the store-theme and click the button to select the store in the pickup facet.

Workspace

Screenshots or example usage:

Gravacao.de.Tela.2024-12-20.as.23.16.03.mov

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@ArthurFerrao ArthurFerrao added the bug Something isn't working label Dec 21, 2024
@ArthurFerrao ArthurFerrao self-assigned this Dec 21, 2024
Copy link

vtex-io-ci-cd bot commented Dec 21, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 21, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ArthurFerrao ArthurFerrao merged commit c2b1cd1 into main Jan 17, 2025
9 checks passed
Copy link

vtex-io-ci-cd bot commented Jan 17, 2025

Your PR has been merged! App is being published. 🚀
Version 0.5.1 → 0.5.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants