Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change moment where pickupPoint is cookied #8

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

hiagolcm
Copy link
Collaborator

What problem is this solving?

When the user adds the zipcode and the page is reloaded, the pickupPoint is not being send to the backend. This is happening because the the API that return the pickuppoints was not being callend before the reload, only after it

Copy link

vtex-io-ci-cd bot commented Oct 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 30, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hiagolcm hiagolcm self-assigned this Nov 5, 2024
@hiagolcm hiagolcm merged commit 8b99394 into main Nov 6, 2024
7 of 8 checks passed
Copy link

vtex-io-ci-cd bot commented Nov 6, 2024

Your PR has been merged! App is being published. 🚀
Version 0.4.1 → 0.4.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants