Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/show more 25 options at organizations auto complete #30

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Fix/show more 25 options at organizations auto complete #30

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebb2bde
fix: [KI 921115] Cost center dropdown shows only 25 options in B2B Ad…
Josmar-jr Jul 25, 2024
bbd5c37
doc: update change log file
Josmar-jr Jul 25, 2024
4a21e8b
fix: [KI 921115] Cost center dropdown shows only 25 options in B2B Ad…
Josmar-jr Jul 25, 2024
9b7dc50
fix: [KI 921115] limits the list of organizations to 500
Josmar-jr Jul 25, 2024
580df09
Update CHANGELOG.md
Josmar-jr Aug 21, 2024
0f92ba7
fix: increase length for search
Josmar-jr Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

- shows more options in the organization dropdown
Josmar-jr marked this conversation as resolved.
Show resolved Hide resolved

### Removed
- [ENGINEERS-1247] - Disable cypress tests in PR level

Expand Down
4 changes: 2 additions & 2 deletions react/components/OrganizationsAutocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const initialState = {
status: ['active', 'on-hold', 'inactive'],
search: '',
page: 1,
pageSize: 25,
pageSize: 500,
sortOrder: 'ASC',
sortedBy: 'name',
}
Expand Down Expand Up @@ -78,7 +78,7 @@ const OrganizationsAutocomplete = ({ onChange, organizationId }: Props) => {
}, [data])

useEffect(() => {
if (term && term.length > 2) {
if (term && term.length > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qual o objetivo dessa mudança?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mudança foi feita para garantir que o useEffect seja disparado sempre que o termo de busca não estiver vazio. Anteriormente, o efeito só era executado quando o termo tinha mais de dois caracteres, o que poderia deixar de capturar casos onde termos menores são relevantes. @ataideverton

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ao permitir que o efeito seja disparado com a primeira entrada, garantimos que o feedback ao usuário seja mais responsivo, evitando a sensação de que a aplicação está ignorando entradas válidas

setHasChanged(true)
refetch({
...initialState,
Expand Down