Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to selectedAddresses when updating OrderForm Shipping Data #119

Closed
wants to merge 2 commits into from

Conversation

rbussola
Copy link

@rbussola rbussola commented Nov 7, 2023

What problem is this solving?
Changing to send selectedAddresses instead of address when updating OrderForm Shipping Data.

Currently, there is a known issue from checkout which impact B2B Suite.

How should this be manually tested?

Screenshots or example usage:

Copy link

vtex-io-ci-cd bot commented Nov 7, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Nov 7, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 6, PR deletions = 2

Generated by 🚫 dangerJS against 851fedb

@enzomerca
Copy link
Contributor

Hey @rbussola! Could you add why we are doing this change to the PR description? What was the problem with using address instead of selectedAddress? What is the behaviour when we use selectedAddress instead of address?

@rbussola
Copy link
Author

rbussola commented Nov 7, 2023

Hi @enzomerca , sorry for not sharing all the context, I created the PR because I had available time and was planning to complete it and make some more tests later, but didn't want to lose what I was testing; that's why I hadn't sent for approval yet. Answering all your questions:

Could you add why we are doing this change to the PR description? What was the problem with using address instead of selectedAddress?

There is a known issue that impacts B2B Suite, and my guess was that it would only happen when the address is sent using the address field and not when using selectedAddresses field, but the hypothesis was discarded after some more tests I did 😞

What is the behaviour when we use selectedAddress instead of address?

In the end, they will behave the same, but from experience, I've seen different validations happening when using each of them.

I'll close the PR, since it has the same behavior and the issue is still happening.

@rbussola rbussola closed this Nov 7, 2023
@rbussola rbussola deleted the selectedAddresses branch November 7, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants