Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce sync roles #121

Merged
merged 3 commits into from
Nov 10, 2023
Merged

fix: reduce sync roles #121

merged 3 commits into from
Nov 10, 2023

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Nov 10, 2023 •
edited
Loading

What problem is this solving?

  • Reduce the call to sync roles

@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Nov 10, 2023 •
edited by Rudge
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 6, PR deletions = 9

Generated by 🚫 dangerJS against c93beb9

@Rudge Rudge requested review from wender and a team November 10, 2023 11:28
@Rudge Rudge force-pushed the hotfix/B2BTEAM-1488-reduce-sync-roles branch from 3fe8e75 to fb68d4d Compare November 10, 2023 11:40
@Rudge Rudge changed the title Hotfix/b2 bteam 1488 reduce sync roles fix: reduce sync roles Nov 10, 2023
@Rudge Rudge marked this pull request as ready for review November 10, 2023 11:44
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Rudge Rudge merged commit 46fb7df into master Nov 10, 2023
19 checks passed
@Rudge Rudge deleted the hotfix/B2BTEAM-1488-reduce-sync-roles branch November 10, 2023 11:56
@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Nov 10, 2023

Your PR has been merged! App is being published. 🚀
Version 1.37.1 → 1.37.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enzomerca enzomerca enzomerca approved these changes

@fredppm fredppm fredppm approved these changes

@wender wender Awaiting requested review from wender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rudge @fredppm @enzomerca