Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addUser to not accept invalid cost center #150

Merged
merged 9 commits into from
Aug 21, 2024

Conversation

giurigaud
Copy link
Contributor

What problem is this solving?
Buyers can't login if there is missconfiguration on cost center

How should this be manually tested?
Call the addUser function in postman, passing an invalid cost center ID

Screenshots or example usage:
image

Copy link

vtex-io-ci-cd bot commented Jul 25, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 25, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@giurigaud
Copy link
Contributor Author

giurigaud commented Jul 25, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@giurigaud giurigaud closed this Jul 25, 2024
@giurigaud giurigaud reopened this Jul 25, 2024
node/typings/custom.d.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 7, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 56, PR deletions = 3

Generated by 🚫 dangerJS against 20dedf9

node/resolvers/Mutations/Users.ts Outdated Show resolved Hide resolved
Copy link

@enzomerca enzomerca merged commit 012d56f into vtex-apps:master Aug 21, 2024
11 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 21, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.1 → 1.44.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants