Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/duplicate orgs - KI-986868: Duplicated organizations #156

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

giurigaud
Copy link
Contributor

@giurigaud giurigaud commented Aug 28, 2024

What problem is this solving?

Duplicated organizations in modal to switch between organizations

How should this be manually tested?

Check if organizations are coming in inconsistently by calling getOrganizationsByEmail using the email: [email protected]

Screenshots or example usage:
Before the change, the data was inconsistent, see the video below

BEFORE.mov

After change, the id returns only one time

Screen.Recording.2024-08-28.at.10.26.03.mov

Copy link

vtex-io-ci-cd bot commented Aug 28, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 28, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@enzomerca enzomerca requested a review from a team September 3, 2024 12:21
@@ -78,6 +78,7 @@ export const getAllUsers = async ({
pageSize: PAGINATION.pageSize,
},
schema: config.version,
sort: 'id asc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future reference:
Master Data might return duplicated entries for very large / paginated requests if sort is not applied.

Copy link

github-actions bot commented Sep 3, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 4, PR deletions = 0

Generated by 🚫 dangerJS against 2a2d652

Copy link

sonarqubecloud bot commented Sep 3, 2024

@enzomerca enzomerca merged commit 5d6bc95 into vtex-apps:master Sep 3, 2024
19 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Sep 3, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.3 → 1.44.4

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants