-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/duplicate orgs - KI-986868: Duplicated organizations #156
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
@@ -78,6 +78,7 @@ export const getAllUsers = async ({ | |||
pageSize: PAGINATION.pageSize, | |||
}, | |||
schema: config.version, | |||
sort: 'id asc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for future reference:
Master Data might return duplicated entries for very large / paginated requests if sort
is not applied.
Quality Gate passedIssues Measures |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Duplicated organizations in modal to switch between organizations
How should this be manually tested?
Check if organizations are coming in inconsistently by calling getOrganizationsByEmail using the email: [email protected]
Screenshots or example usage:
Before the change, the data was inconsistent, see the video below
BEFORE.mov
After change, the id returns only one time
Screen.Recording.2024-08-28.at.10.26.03.mov