Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [KI 1055033] - geocoordinates #160

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

giurigaud
Copy link
Contributor

@giurigaud giurigaud commented Sep 13, 2024

What problem is this solving?

Products unavailable in the cart

How should this be manually tested?

Screenshots or example usage:

Screenshot 2024-09-25 at 17 32 57

NOTE: for the product to appear as available in the search, the PR vtex-apps/b2b-theme#11 must also be merged

Copy link

vtex-io-ci-cd bot commented Sep 13, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@giurigaud giurigaud marked this pull request as draft September 13, 2024 13:10
@giurigaud giurigaud marked this pull request as ready for review September 25, 2024 20:18
@giurigaud giurigaud changed the title draft: [KI 1055033] - geocoordinates fix: [KI 1055033] - geocoordinates Sep 25, 2024
@enzomerca enzomerca requested a review from a team September 30, 2024 14:46
Copy link

github-actions bot commented Sep 30, 2024

Warnings
⚠️

package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 28, PR deletions = 8

Generated by 🚫 dangerJS against f9c1776

@enzomerca
Copy link
Contributor

Fails
🚫
We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Messages
📖 ❤️ Thanks!
📖
🎉 PR additions = 30, PR deletions = 14

Generated by 🚫 dangerJS against 6e31eab

Please, update the changelog!

Copy link

@enzomerca enzomerca merged commit 1640c7e into vtex-apps:master Oct 14, 2024
19 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 14, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.11 → 1.44.12

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants