Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary b2b_users storage on vbase #161

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

enzomerca
Copy link
Contributor

@enzomerca enzomerca commented Sep 20, 2024

What problem is this solving?

The b2b_users data on vbase was only being written but never read. This PR removes this entity usage from vbase.

This data was originally read on the checkPermissions function, but it was removed months ago due to an issue with vbase.

Now, this is the use cases that writes the most to vbase, but is its data is never read, hence, there is no point in keeping it.

@enzomerca enzomerca requested a review from a team September 20, 2024 20:00
Copy link

vtex-io-ci-cd bot commented Sep 20, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 20, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Sep 20, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 9, PR deletions = 24

Generated by 🚫 dangerJS against b06b47f

Copy link

@enzomerca enzomerca requested a review from wender September 23, 2024 14:24
Copy link
Collaborator

@wender wender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enzomerca enzomerca merged commit 10d48ce into master Sep 25, 2024
13 checks passed
@enzomerca enzomerca deleted the fix/remove-b2b-users-from-vbase branch September 25, 2024 14:32
Copy link

vtex-io-ci-cd bot commented Sep 25, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.6 → 1.44.7

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants