Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session: return early if storeUserEmail is not populated #163

Merged
merged 4 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,64 +7,80 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Fixed

- In session provider, return early if storeUserEmail is not populated

## [1.44.7] - 2024-09-25

### Fixed

- Remove unnecessary b2b_users storage on vbase

## [1.44.6] - 2024-09-05

### Fixed

- Add await to requests to properly handle inactive organizations on login

## [1.44.5] - 2024-09-04

### Fixed

- Provide app token on calls to b2b-organizations-graphql app

## [1.44.4] - 2024-09-03

### Fixed

- Add sort to searchDocumentsWithPaginationInfo at getAllUsers

## [1.44.3] - 2024-08-22

### Fixed

- add new auth metric field

## [1.44.2] - 2024-08-21

### Fixed

- addUser function to not accept invalid cost center

## [1.44.1] - 2024-08-19

### Added

- Session audit metrics

## [1.44.0] - 2024-08-14

### Changed

- Changed the token validation directive of some operations

## [1.43.5] - 2024-08-08

### Fixed

- Storefront considers the active organizations when setting the user's profile

## [1.43.4] - 2024-08-07

### Changed

- Changed the token validation directive of some operations

## [1.43.3] - 2024-07-31

### Changed

- Changed the token validation directive of some operations

## [1.43.2] - 2024-07-29

### Added

- Add enforcement of new validation for admin and api tokens
- Add more details to admin and api token validation metric

Expand Down
9 changes: 1 addition & 8 deletions node/resolvers/Routes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const Routes = {

const ignoreB2B = body?.public?.removeB2B?.value

if (ignoreB2B) {
if (ignoreB2B || !email) {
ctx.response.body = response
ctx.response.status = 200

Expand Down Expand Up @@ -212,13 +212,6 @@ export const Routes = {
email = telemarketingEmail
}

if (!email) {
ctx.response.body = response
ctx.response.status = 200

return
}

if (user === null) {
user = (await getActiveUserByEmail(null, { email }, ctx).catch(
(error) => {
Expand Down
Loading