Support inference extra props from as props #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add support to merge props from the component passed in prop
as
.What problem is this solving?
Correct type detection of new props when
as
is passed.How should this be manually tested?
The examples of
Button.stories.tsx
could have correct type.Checkbox
has changed to composeButton
witha
andLink
, instead composeCheckbox
withButton
, so the props ofa
andLink
must be merged with theButton
in this cases.as
should merge the props ofThemeAwareButton
by default.Screenshots or example usage
Before:
After:
Types of changes
How does this PR make you feel? 🔗
Notes
I need to cast the return of
forwardRef
, becauseforwardRef
don't pass the generics forward.