generated from vtex-sites/base.store
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add 'optionalDependencies' to package.json #13
Draft
heitorado
wants to merge
2
commits into
main
Choose a base branch
from
chore/fsss-306-add-optional-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−24
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about this, but when WebOps builds for production, doesn't it already skip all the
devDependenciesbecauseNODE_ENVis set toproduction(I'd hope)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filipewl It does not because it has to run the tests and the lighthouse checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But for building the static pages, I don't think they need to install the dev dependencies...
The tests and LH checks are run on their own separate pipeline run and in these cases they do install the dev dependencies to run the proper commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filipewl, indeed the devDependencies are not needed for building the static pages, as well as the tests and LH checks have separate pipelines.
However, if you look at our tekton dashboard and browse the pipelines' code, you'll notice that they share the same common task, called
clone. Thisclonetask is responsible for, among other things, runningyarn installfor the cloned repo in the CI environment. Since this task is shared between pipelines, we need to fill theoptionalDependencieswith the packages used in all pipelines, letting out only things we use locally, such as thestorybookandeslint.I agree that different tasks like
clone-for-testandclone-for-buildwould be better, but:yarndoes not support other sections besidesoptionalDependencies. If they had support fortestDependenciesandbuildDependenciesthat would be great.We could investigate alternatives about to reduce the install time even further, maybe at webops level we could run different
yarn installcommands depending on the pipeline. But that is a story for another PR :)