feat: Custom Cypress tests #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 1ed261a
|
This reverts commit ed7fd63.
hellofanny
reviewed
Nov 1, 2023
| @@ -70,6 +70,7 @@ module.exports = { | |||
| experimental: { | |||
| nodeVersion: 18, | |||
| cypressVersion: 12, | |||
| enableCypressExtension: true, | |||
There was a problem hiding this comment.
Are we going to enable it as default? I think we shouldn't, the user should enable it when needed, WTDY?
There was a problem hiding this comment.
Yep, we won't change that, it was just for testing purposes 🤝
lucasfp13
added a commit
to vtex/faststore
that referenced
this pull request
Nov 1, 2023
## What's the purpose of this pull request? This PR intends to fix some details regarding stores' custom Cypress tests. ### Starters Deploy Preview vtex-sites/starter.store#237 --------- Co-authored-by: Mariana Caetano Pereira <[email protected]>
emersonlaurentino
approved these changes
Nov 1, 2023
|
@lucasfp13 should we merge this PR or #244? |
No, we don't need to merge this PR as it was created for testing purposes only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to setup the Cypress test extension.
How to test it?
Faststore related PRs
vtex/faststore#2080