Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test without next dependency #356

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jan 16, 2024

Depends on

What's the purpose of this pull request?

This PR aims to remove the NextJS, react, and react-dom versions from the starters and keep just the @faststore/core dependencies.

Main advantages:

  • we just need to maintain these libs in one place: inside the @faststore/core.

Main disadvantages:

  • The visibility of the version used is not available in the starter anymore, just in @faststore/core.

How does it work?

Questions:

  1. But how do we build components and use these libs in our starter?
  • It's possible to import indirectly once these libs are part of @faststore/core. See the example in this PR: TBD.
  1. Do we lose the autocomplete/autoimport feature?
  • once install the types, it's possible to use this feature yet.
"@types/next": "^9.0.0",
"@types/react": "^18.2.48",

How to test it?

You can use the related example PR here.

Faststore related PRs

Copy link

vtex-sites bot commented Jan 17, 2024

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 52a1700

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@eduardoformiga
Copy link
Member Author

eduardoformiga commented Jan 23, 2024

Closed due to poor DX auto-import, and getting Next js version issues when they are not a direct dependency.

see the final result here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant