Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Malta country rules #560

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Add Malta country rules #560

merged 3 commits into from
Apr 26, 2024

Conversation

GeorgeLimaDev
Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev commented Apr 24, 2024

What is the purpose of this pull request?

It relates to the task LOC-14346. Adds country rules for the country of Malta (MLT).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

vtex-io-ci-cd bot commented Apr 24, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@GeorgeLimaDev GeorgeLimaDev marked this pull request as ready for review April 25, 2024 11:22
@GeorgeLimaDev GeorgeLimaDev requested review from kaio-donadelli, sheilagomes and a team April 25, 2024 11:22
Copy link
Contributor

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

react/countries.js Outdated Show resolved Hide resolved
@jeffersontuc
Copy link
Contributor

Hi, @GeorgeLimaDev
This address-form version is not used on the Checkout, so I'm afraid the test plan for #559 doesn't fit for this PR. I would suggest to test theses changes on MyAccount's side, since I suppose is the place where this 4.x major is mainly used.

You can ask for help from the OrderManagement team, in case you need it.

Co-authored-by: Jefferson Benedito <[email protected]>
@jeffersontuc jeffersontuc merged commit 30e4501 into 4.x Apr 26, 2024
8 checks passed
@jeffersontuc jeffersontuc deleted the loc/14346-4x branch April 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants